Hi Guennadi, On Tue, Oct 23 2012, Guennadi Liakhovetski wrote: > A recent commit "mmc: sh_mmcif: fix clock management" has introduced a use > after free bug in sh_mmcif.c: in sh_mmcif_remove() the call to > mmc_free_host() frees private driver data, therefore using it afterwards > is a bug. Revert that hunk. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > --- > > Chris, the offending patch appeared in 3.6, so, this has to go to > 3.6.stable, as well as to 3.7-rc. > > drivers/mmc/host/sh_mmcif.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c > index 11d2bc3..d25bc97 100644 > --- a/drivers/mmc/host/sh_mmcif.c > +++ b/drivers/mmc/host/sh_mmcif.c > @@ -1466,9 +1466,9 @@ static int __devexit sh_mmcif_remove(struct platform_device *pdev) > > platform_set_drvdata(pdev, NULL); > > + clk_disable(host->hclk); > mmc_free_host(host->mmc); > pm_runtime_put_sync(&pdev->dev); > - clk_disable(host->hclk); > pm_runtime_disable(&pdev->dev); > > return 0; Thanks, pushed to mmc-next for 3.7. In future, feel free to note the stable@ situation by adding: Cc: stable@xxxxxxxxxxxxxxx [3.6] - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
