Hi, On Fri, Oct 19 2012, Heiko Stübner wrote: > Am Freitag, 19. Oktober 2012, 10:04:14 schrieb Seungwon Jeon: >> On Thursday, October 18, 2012, Heiko Stuebner <heiko@xxxxxxxxx> >> >> > If host clock is disabled, host cannot detect a card >> > in case of using the internal or gpio card-detect for detection. >> > >> > Signed-off-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx> >> > Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> >> > --- >> > I've added the SDHCI_CD_GPIO to the conditional. With this change it >> > works on my machine. But I'm not sure if this would also be necessary >> > for the external card detect. >> >> Card detection will be asserted out of host in case of using SDHCI_CD_GPIO. >> Adding SDHCI_CD_GPIO to the conditional seems unnecessary. > > But it _was_ necessary :-) . Because only then did the problem go away. You > might be right, that there exists a better solution for this, but something in > the original patch is at least still missing to fix the problem. Seungwon, what would you like to do here? (I'm unhappy taking a patch with your name on it that's been modified in a way you disagree with.) Thanks, - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
