Re: [PATCH] MMCI: fetch pinctrl handle and set default state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 22, 2012 at 09:52:06AM +0200, Linus Walleij wrote:
> +	/* enable pins to be muxed in and configured */
> +	if (!IS_ERR(host->pins_default)) {
> +		ret = pinctrl_select_state(host->pinctrl, host->pins_default);
> +		if (ret)
> +			dev_err(&dev->dev, "could not set default pins\n");
> +	} else
> +		dev_err(&dev->dev, "could not get default pinstate\n");

Umm, are these errors or warnings?  Arguably, because we continue,
these seem to me to be warnings.

In my mind, a warning message is one which is reporting a condition which
we can continue from, whereas an error message is a condition which causes
immediate failure.  (Think about GCC... with warnings you still get code,
but the code may not be correct, but if you see an error message you don't
get any code.)
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux