Friday, October 26, 2012, Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> I think right that dw_mci_setup_bus() is called into set_ios().
> Actually clock is enabled at dw_mci_setup_bus() in now.
> Then didn't ensure to wait the 74clock.
This will be ensured when first command is sent
with 'send_initialization' flag of CMD register.
But I feel this change is reasonable.
Looks good to me if commit message is modified.
Acked-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx>
Thanks.
Seungwon Jeon
> To stable clock is relocated the position into dw_mci_set_ios().
>
> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/mmc/host/dw_mmc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 250aa18..9001844 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -682,9 +682,6 @@ static void __dw_mci_start_request(struct dw_mci *host,
> if (host->pdata->select_slot)
> host->pdata->select_slot(slot->id);
>
> - /* Slot specific timing and width adjustment */
> - dw_mci_setup_bus(slot);
> -
> host->cur_slot = slot;
> host->mrq = mrq;
>
> @@ -810,6 +807,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> if (slot->host->drv_data->set_ios)
> slot->host->drv_data->set_ios(slot->host, ios);
>
> + /* Slot specific timing and width adjustment */
> + dw_mci_setup_bus(slot);
> +
> switch (ios->power_mode) {
> case MMC_POWER_UP:
> set_bit(DW_MMC_CARD_NEED_INIT, &slot->flags);
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
