Can you fix your mailer to use bottom posting rather than top posting, and have texts wrap around column 70? Otherwise, you message stands a good chance to be ignored by people. On Wed, Oct 17, 2012 at 11:27:17PM -0700, Yong Ding wrote: > Shawn, > Thanks. Oh, sorry I really have missed the fact u mentioned. U are right in the current code, the bit will also be cleared for ESDHC_CD_GPIO. > But I think this is improper since for GPIO detection type, we don't use the host controller internal card detection(ESDHC_CD_CONTROLLER), but with SDHCI_QUIRK_BROKEN_CARD_DETECTION cleared, we'll still enable/disable relevant INT bits (in sdhci_set_card_detection in sdhci.c). This is my biggest concern. And I think the SDHCI_QUIRK_BROKEN_CARD_DETECTION shall be purely used to notify whether the host controller detection method is used or not. So even for the ESDHC_CD_GPIO type, we should still set this flag. How do u think? > I'm fine with that. Just remind you a fact you seem missed in case you need to change sdhci-esdhc-imx.c to adapt the changes you are going to make on sdhci.c. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
