Monday, October 01, 2012, Will Newton <will.newton@xxxxxxxxx> wrote: > On Fri, Sep 28, 2012 at 10:36 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver > > points to the wrong symbol which results in a link error > > when building as a loadable module. > > > > Further, we get a warning about the driver_data being > > marked constant, which requires annotating a few pointers > > as const. > > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: Chris Ball <cjb@xxxxxxxxxx> > > Cc: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > > Cc: Will Newton <will.newton@xxxxxxxxxx> > > Cc: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> > > Cc: Seungwon Jeon <tgih.jun@xxxxxxxxxxx> > > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > Cc: linux-mmc@xxxxxxxxxxxxxxx > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 4 ++-- > > drivers/mmc/host/dw_mmc-pltfm.c | 2 +- > > drivers/mmc/host/dw_mmc-pltfm.h | 2 +- > > drivers/mmc/host/dw_mmc.c | 2 +- > > include/linux/mmc/dw_mmc.h | 2 +- > > 5 files changed, 6 insertions(+), 6 deletions(-) > > This looks ok to me, but I'll let one of the Exynos guys ack those > specific changes as I don't have the hardware. > > There's already a patch for the dev_info warning in dw_mmc.c frm > Seungwon Jeon, and it seems to me like a separate change but I don't > really mind how it gets merged. Looks good to me. I don't mind it about including 'dev_info warning'. Acked-by: Seungwon Jeon<tgih.jun@xxxxxxxxxxx> > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
