Hi Ulf, On Thu, Sep 13 2012, Ulf Hansson wrote: > From: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > This patch fixup the broken suspend sequence for eMMC > with sleep support. Additionally it reworks the eMMC4.5 > Power Off Notification feature so it fits together with > the existing sleep feature. > > The CMD0 based re-initialization of the eMMC at resume > is re-introduced to maintain compatiblity for devices > using sleep. > > A host shall use MMC_CAP2_POWEROFF_NOTIFY to enable the > Power Off Notification feature. We might be able to > remove this cap later on, if we think that Power Off > Notification always is preferred over sleep, even if the > host is not able to cut the eMMC VCCQ power. > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > Signed-off-by: Saugata Das <saugata.das@xxxxxxxxxx> > CC: Girish K S <girish.shivananjappa@xxxxxxxxxx> > CC: Asutosh Das <asutoshd@xxxxxxxxxxxxxx> I gave this patch a try on a board with an eMMC 4.41, but it didn't resolve the crash that I see. After applying the patch, I still see: [ 25.191917] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done. [ 25.319299] mmc1: Got data interrupt 0x00000002 even though no data operation was in progress. [ 25.335054] PM: Device d4281000.sdhci failed to suspend: error -110 [ 25.341461] PM: Some devices failed to suspend and the suspend aborts. If I modify mmc_card_can_sleep() to always return false, the suspend completes without errors, so I know that something in the sleep code is responsible for my crash. Any suggestions? Perhaps it's a different bug in the eMMC sleep code. Thanks, - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
