>> +static inline void exynos_set_clk_drv_sample(struct dw_mci *host, >> + struct mmc_ios *ios) >> +{ >> + u32 regs, ratio; >> + >> + regs = mci_readl(host, EXYNOS_CLKSEL); >> + ratio = SDMMC_GET_DIV_RATIO(reg); >> + if (!ratio) { >> + regs &= ~SDMMC_CLK_RESET_DRV_SAMPLE; >> + regs |= ratio; >> + if (ios->timing == MMC_TIMING_UHS_DDR50) >> + regs |= host->pdata->ddr_timing; >> + else >> + regs |= host->pdata->sdr_timing; > > Ah right, I see you're using them from a different patch. It feels wrong > to platform specific data within the general platform data structure as > it would be there unused for every other platform. Perhaps it would be > better to have an outer exynos platform data struct which contains the > standard one, and then use container_of to access it using the pointer > to the inner one. Does that make sense? I will check this. thanks for comment.. Best Regards, Jaehoon Chung > >> + } else >> + regs &= ~SDMMC_CLK_RESET_DRV_SAMPLE; >> + >> + mci_writel(host, EXYNOS_CLKSEL, regs); >> +} >> + >> +#endif /* _EXYNOS_DW_MMC_H */ >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html