On 08/29/2012 10:22 AM, Seungwon Jeon wrote: > On Tuesday, August 28, 2012, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote: > Commit message is no need? > >> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >> --- >> include/linux/mmc/exynos-dw_mmc.h | 61 +++++++++++++++++++++++++++++++++++++ >> 1 files changed, 61 insertions(+), 0 deletions(-) >> create mode 100644 include/linux/mmc/exynos-dw_mmc.h >> >> diff --git a/include/linux/mmc/exynos-dw_mmc.h b/include/linux/mmc/exynos-dw_mmc.h >> new file mode 100644 >> index 0000000..3a6b08b >> --- /dev/null >> +++ b/include/linux/mmc/exynos-dw_mmc.h >> @@ -0,0 +1,61 @@ >> +/* >> + * Synopsys DesignWare Multimedia Card Interface driver >> + * >> + * Copyright (c) 2012 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * Header file for Exynos specific register >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#ifndef _EXYNOS_DW_MMC_H >> +#define _EXYNOS_DW_MMC_H >> +#include <linux/mmc/dw_mmc.h> >> +#include <linux/mmc/host.h> >> + >> +#define SDMMC_EXYNOS_CLKSEL 0x09C >> + >> +#define SDMMC_GET_CLK_DRV(x) ((x) >> 16 & 0x7) >> +#define SDMMC_GET_CLK_SAMPLE(x) ((x) & 0x7) >> +#define SDMCM_GET_DIVRATIO(x) ((x) >> 24 & 0x7) >> +#define SDMMC_CLK_RESET_DRV_SAMPLE (0x07070007); >> + >> +#define mci_readl(dev, reg) \ >> + __raw_readl((dev)->regs + SDMMC_##reg) >> +#define mci_writel(dev, reg, value) \ >> + __raw_writel((value), (dev)->regs + SDMMC_##reg) >> + >> +static inline int exynos_get_clk_drv(struct dw_mci *host) >> +{ >> + return SDMMC_GET_CLK_DRV(mci_readl(host, EXYNOS_CLKSEL)); >> +} >> + >> +static inline int exynos_get_clk_sample(struct dw_mci *host) >> +{ >> + return SDMMC_GET_CLK_DRV(mci_readl(host, EXYNOS_CLKSEL)); >> +} >> + >> +static inline void exynos_set_clk_drv_sample(struct dw_mci *host, >> + struct mmc_ios *ios) >> +{ >> + u32 regs, ratio; >> + >> + regs = mci_readl(host, EXYNOS_CLKSEL); >> + ratio = SDMMC_GET_DIV_RATIO(reg); >> + if (!ratio) { > Perhaps, "if (ratio)" is right? Right ratio is set to 0, drv/sample value must set to 0. It's my mistake. > Anyway, I feel this patch with "mmc: dw-mmc: add the platdata related with clock" > is overlapped. It needs to be adjusted. Ok, thanks for comment. Best Regards, Jaehoon Chung > > >> + regs &= ~SDMMC_CLK_RESET_DRV_SAMPLE; >> + regs |= ratio; >> + if (ios->timing == MMC_TIMING_UHS_DDR50) >> + regs |= host->pdata->ddr_timing; >> + else >> + regs |= host->pdata->sdr_timing; >> + } else >> + regs &= ~SDMMC_CLK_RESET_DRV_SAMPLE; >> + >> + mci_writel(host, EXYNOS_CLKSEL, regs); >> +} >> + >> +#endif /* _EXYNOS_DW_MMC_H */ >> -- >> 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
