Hi Chris, Thanks for your review. On 16 August 2012 21:17, Chris Ball <cjb@xxxxxxxxxx> wrote: > Hi Thomas, > > On Thu, Aug 16 2012, Thomas Abraham wrote: >> Add device tree based discovery support for Samsung's sdhci controller >> >> Cc: Ben Dooks <ben-linux@xxxxxxxxx> >> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> >> Cc: Chris Ball <cjb@xxxxxxxxxx> >> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> >> --- >> drivers/mmc/host/sdhci-s3c.c | 146 ++++++++++++++++++++++++++++++++++++++++-- >> 1 files changed, 140 insertions(+), 6 deletions(-) > > I know your initial version was submitted before we adopted a set of > standard MMC DT bindings, but now that those bindings exist this code > should be using them -- there should be a new file: > Documentation/devicetree/bindings/mmc/sdhci-s3c.txt > describing differences between the mmc.txt bindings and this driver's. Sorry, I missed that. I will resend this patch with the documentation. > > Also, you didn't include a patch changelog, so I can't tell whether this > contains changes against your v3 of this patch; please do that. Yes, I missed the changelog as well. I will add it in the next version of this patch. Thanks, Thomas. > > Thanks! > > - Chris. > -- > Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> > One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
