MMC_QUIRK_SEC_ERASE_TRIM_BROKEN seems quite clear but I might not use "SEC" due to it could be Samsung Electronics Corporation. So, how about MMC_QUIRK_SECDISCARD_BROKEN which was used in mmc_blk_issue_secdiscard_rq() naming, the function we skip. Or, MMC_QUIRK_SECERASE_SECTRIM_BROKEN? Regards, Ian -----Original Message----- From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] Sent: Tuesday, August 14, 2012 5:07 PM To: IAN CHEN Cc: cjb@xxxxxxxxxx; linkinjeon@xxxxxxxxx; adrian.hunter@xxxxxxxxx; subhashj@xxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; d.j.shin@xxxxxxxxxxx; jongtae22.kim@xxxxxxxxxxx; kyungmin.park@xxxxxxxxxxx; jh80.chung@xxxxxxxxxxx Subject: Re: [PATCH v3] mmc: card: Skip secure option for MoviNAND. On Tue, Aug 14, 2012 at 9:06 AM, IAN CHEN <ian.cy.chen@xxxxxxxxxxx> wrote: > +#define MMC_QUIRK_SECURE_MODE_BROKEN (1<<10) /* Skip secure for > erase/trim */ OK this will work and sorry for being picky, but we are working with RPMB support and that's some other "secure mode" so to avoid any misuderstandings it's better to name the flag like I proposed, MMC_QUIRK_SEC_ERASE_TRIM_BROKEN I won't die if this goes in though :-) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
