Hi. Ian. Okay, I see. plz add this address in changelog. I also agree about Linus's suggestion. So Would you change flag name to be neutral ? We can distinguish samsung movinand by CID_MANFID_SAMSUNG. And will reuse quirk flag when same issue occurred from other vendor's mmc deivce. Thanks. 2012/8/14, IAN CHEN <ian.cy.chen@xxxxxxxxxxx>: > Dear Mr. Jeon, > > This is workaround for some Samsung eMMC, MoviNAND. > There are known issue about secure erase & secure trim with these eMMC > device which I listed by product_name. > Therefore, for these eMMC devices, we just skip > mmc_blk_issue_secdiscard_rq() and use mmc_blk_issue_discard_rq() instead. > > You could refer this discussion in XDA developers. > http://forum.xda-developers.com/showthread.php?t=1644364 > > https://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB > > Regards, > Ian > > -----Original Message----- > From: Namjae Jeon [mailto:linkinjeon@xxxxxxxxx] > Sent: Monday, August 13, 2012 10:03 PM > To: IAN CHEN > Cc: cjb@xxxxxxxxxx; adrian.hunter@xxxxxxxxx; subhashj@xxxxxxxxxxxxxx; > linus.walleij@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; d.j.shin@xxxxxxxxxxx; > jongtae22.kim@xxxxxxxxxxx; kyungmin.park@xxxxxxxxxxx; > jh80.chung@xxxxxxxxxxx > Subject: Re: [PATCH] mmc: card: Skip secure option for MoviNAND. > > Hi. Ian. > > known issue ? Would you explain more ? > > Thanks. > > 2012/8/13 IAN CHEN <ian.cy.chen@xxxxxxxxxxx>: >> From 5c60eb8be04c7440d6e33b8f72ea2046a3657ac4 Mon Sep 17 00:00:00 2001 >> From: ian.cy.chen <ian.cy.chen@xxxxxxxxxxx> >> Date: Mon, 13 Aug 2012 10:53:55 +0900 >> Subject: [PATCH] mmc: card: Skip secure option for MoviNAND. >> >> For several MoviNAND, there are some known issue with secure option. >> For these specific MoviNAND device, we skip secure option. >> >> Signed-off-by: Ian Chen <ian.cy.chen@xxxxxxxxxxx> >> --- >> drivers/mmc/card/block.c | 24 +++++++++++++++++++++++- >> include/linux/mmc/card.h | 1 + >> 2 files changed, 24 insertions(+), 1 deletions(-) >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
