On Thu, Aug 09, 2012 at 11:27:02AM +0200, Rafael J. Wysocki wrote: > On Thursday, August 09, 2012, Thierry Reding wrote: > > Power management callbacks defined by SIMPLE_DEV_PM_OPS are only used if > > the PM_SLEEP Kconfig symbol has been defined. If not, the compiler will > > complain about them being unused. > > > > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> > > The pm_no_operation() thing is not necessary at all, AFAICT. I'd just > remove it entirely. :-) I don't actually have a setup where I can test suspend/resume with this driver, but if you say so I can follow up with a patch that removes pm_no_operation(). It should work because many drivers without proper PM_SLEEP support do not specify .suspend() nor .resume() callbacks either. Thierry
Attachment:
pgpuFNu6jN2BT.pgp
Description: PGP signature
