Re: [PATCH 2/3] mmc: dw_mmc: correct mishandling error interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Jul 31 2012, Seungwon Jeon wrote:
> Datasheet of SYNOPSYS mentions that DTO(Data Transfer Over) interrupt
> will be raised even if some error interrupts, however it is actually
> found that DTO does not occur. SYNOPSYS has confirmed this issue.
> Current implementation defers the call of tasklet_schedule until DTO
> when the error interrupts is happened. This patch fixes error handling.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx>
> ---
>  drivers/mmc/host/dw_mmc.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 7baed45..1a5db20 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1580,9 +1580,7 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
>  			host->data_status = pending;
>  			smp_wmb();
>  			set_bit(EVENT_DATA_ERROR, &host->pending_events);
> -			if (!(pending & (SDMMC_INT_DTO | SDMMC_INT_DCRC |
> -					 SDMMC_INT_SBE | SDMMC_INT_EBE)))
> -				tasklet_schedule(&host->tasklet);
> +			tasklet_schedule(&host->tasklet);
>  		}
>  
>  		if (pending & SDMMC_INT_DATA_OVER) {

Thanks, pushed to mmc-next for 3.7.

- Chris.
-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux