On Wed, Jul 18, 2012 at 3:08 PM, S, Venkatraman <svenkatr@xxxxxx> wrote: > On Wed, Jul 18, 2012 at 2:46 PM, Javier Martinez Canillas > <martinez.javier@xxxxxxxxx> wrote: [...] >>>> >>>> And what about enabling it at the SoC config level but making the >>>> drivers dependant on CONFIG_DMADEVICES and CONFIG_DMA_OMAP? If you >>>> agree I can send something like this in two different patches (one for >>>> the omap2plus_defconfig and another to make the drivers dependant on >>>> the config option): >>>> >>>> diff --git a/arch/arm/configs/omap2plus_defconfig >>>> b/arch/arm/configs/omap2plus_defconfig >>>> index b152de7..e58edc3 100644 >>>> --- a/arch/arm/configs/omap2plus_defconfig >>>> +++ b/arch/arm/configs/omap2plus_defconfig >>>> @@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y >>>> CONFIG_RTC_CLASS=y >>>> CONFIG_RTC_DRV_TWL92330=y >>>> CONFIG_RTC_DRV_TWL4030=y >>>> +CONFIG_DMADEVICES=y >>>> +CONFIG_DMA_OMAP=y >>>> CONFIG_EXT2_FS=y >>>> CONFIG_EXT3_FS=y >>>> # CONFIG_EXT3_FS_XATTR is not set >>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >>>> index aa131b3..314c7bd 100644 >>>> --- a/drivers/mmc/host/Kconfig >>>> +++ b/drivers/mmc/host/Kconfig >>>> @@ -231,7 +231,7 @@ config MMC_SDHCI_S3C_DMA >>>> >>>> config MMC_OMAP >>>> tristate "TI OMAP Multimedia Card Interface support" >>>> - depends on ARCH_OMAP >>>> + depends on ARCH_OMAP && DMADEVICES && DMA_OMAP >>> >>> May be. But since for sure a driver knows that it needs DMA >>> support to be enabled, I will just select it rather than depends >>> on. >>> >>> Regards >>> santosh >> >> Yes I agree with you, I was just exploring other options :-) >> > For MMC atleast, there's already a patch in mmc-next to do a "Depends On" > http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commit;h=7c68046c99f0b96d965c31cf42814b9a0f15ad46 Change log assumes says . "The patch simply make them depend on DMA_OMAP since DMA_OMAP will select DMA_ENGINE automatically" This won't be true if the DMA selection are not done at ARCH_OMAP level as discussed in this thread. Having said that, I think Russell and Tony need to take call on how this needs to be handled. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
