On 10 July 2012 23:02, Chris Ball <cjb@xxxxxxxxxx> wrote:
> Hi,
>
> On Tue, Jul 10 2012, Girish K S wrote:
>>> @@ -2063,7 +2074,8 @@ void mmc_rescan(struct work_struct *work)
>>>
>>> void mmc_start_host(struct mmc_host *host)
>>> {
>>> - mmc_power_off(host);
>>> + host->f_init = max(freqs[0], host->f_min);
>>> + mmc_power_up(host);
>>> mmc_detect_change(host, 0);
>>> }
>>>
>> sorry to comment late on this.
>> This patch breaks the card detect with the designware host controller.
>> Anybody using the same host controller please let me know.
>> The problem is caused by the power_up call from the mmc_start_host
>> function. If i comment this powerup then card detect is fine
>
> Thanks. Ulf, sounds like we should revert this for 3.5-rc (which would
> have to happen soon) while we investigate; let me know what you think.
power_up function in the mmc_start_host can be completely omitted as
it will be anyway called in the mmc_detect_change.
I will test this change on the available host controllers and will
publish the result. If this removal doesnt cause any side affect, will
post it as a patch.
Ulf,
waiting for your comments on the same
>
> - Chris.
> --
> Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
