Re: [PATCH v1 5/5] mmc: card: Add RPMB support in IOCTL interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Repost in text format

2012/7/10 Namjae Jeon <linkinjeon@xxxxxxxxx>
>
> >
> > +     err = mmc_blk_part_switch(card, md);
> > +     if (err)
> > +             goto cmd_rel_host;
> > +
> Should it wrapped by if (is_rpbm) condition ? It can be called in other
> ioctl.
It was my first implementation, but in that case you have to manage a
session, switching on RPMB partition at the begining of the IOCTL and
restore previous partition at the end. (because RPMB partition doesn't
support all commands).

Having a look to how mmc driver manages partition selection, I saw
that mmc_blk_issue_rq for instance calls mmc_blk_part_switch in the
beginning to be sure it's on the right partition, but never restores

The proposal is to use same way and to make it compliant with Boot and
GP partitions if there are any special commands supported by them.
>
> >       if (idata->ic.is_acmd) {
> >               err = mmc_app_cmd(card->host, card);
> >               if (err)
> >                       goto cmd_rel_host;
> >       }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux