Hi Chris,
Can we push this change to mmc-next?
Thanks,
Maya
On Mon, July 9, 2012 10:40 pm, merez@xxxxxxxxxxxxxx wrote:
>
> On Mon, July 9, 2012 3:13 am, Seungwon Jeon wrote:
>> Monday, July 09, 2012, Maya <merez@xxxxxxxxxxxxxx> wrote:
>>> On Sun, July 8, 2012 4:52 pm, Seungwon Jeon wrote:
>>> > Sunday, July 08, 2012, Maya <merez@xxxxxxxxxxxxxx> wrote:
>>> >> One minor comment below:
>>> >>
>>> >> > @@ -1278,9 +1609,15 @@ static int mmc_blk_issue_rw_rq(struct
>>> mmc_queue
>>> >> *mq, struct request *rqc)
>>> >> > (card->ext_csd.data_sector_size == 4096)) {
>>> >> You can use mmc_large_sec here (instead of
>>> >> card->ext_csd.data_sector_size
>>> >> == 4096)
>>> > Yes, but this line is kept due to another issue related with 4KB
>>> sector.
>>> >
>>> > Thanks,
>>> > Seungwon Jeon
>>> Hi,
>>>
>>> I'm not sure I understand your reply. mmc_large_sec does exactly what
>>> the
>>> if here does.
>>> My suggestion is to replace the code with the new function you added.
>>> I agree it's an old code but this way the code will be consistent and
>>> mmc_large_sec will be used in every place we would like to check if the
>>> sector size is 4K.
>> I just remained. The code you pointed can be replaced.
>> Regardless this review, I'll rework.
>> eMMC 4.51 spec was updated in June and there is some changes.
>> Spec mentions packed header is 8 blocks in 4KB native device.
>> I'll apply this change.
> No need to apply the change.
> You are probably right and since it is not related to your change it can
> be done later on.
>>
>> Thanks,
>> Seungwon Jeon
>>
>>>
>>> Thanks,
>>> Maya
>>>
>>> --
>>> Sent by consultant of Qualcomm Innovation Center, Inc.
>>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>
>
> --
> Sent by consultant of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
>
>
--
Sent by consultant of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
