Hi Aaron, On Tue, Jul 03 2012, Aaron Lu wrote: > On Fri, Jun 29, 2012 at 07:19:19PM -0400, Chris Ball wrote: >> Hi, >> >> On Fri, Jun 08 2012, philipspatches@xxxxxxxxx wrote: >> > From: Philip Rakity <prakity@xxxxxxxxxxx> >> > >> > If we are using a regulator the SD Host Controller and the >> > regulator should agree about the voltages supported. Use >> > the common subset that is supported. >> > >> > Signed-off-by: Philip Rakity <prakity@xxxxxxxxxxx> >> >> This breaks the build when CONFIG_REGULATOR=n -- I've applied what looks >> like the correct fix to me: >> >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >> index eae7c3c..caba999 100644 >> --- a/drivers/mmc/host/sdhci.c >> +++ b/drivers/mmc/host/sdhci.c >> @@ -2832,51 +2832,53 @@ int sdhci_add_host(struct sdhci_host *host) >> +#ifdef CONFIG_REGULATOR >> /* >> * According to SD Host Controller spec v3.00, if the Host System >> * can afford more than 150mA, Host Driver should set XPC to 1. Also >> * the value is meaningful only if Voltage Support in the Capabilities >> * register is set. The actual current value is 4 times the register >> * value. >> */ > The above comments does not belong to regulator code, it should be > placed on top of the max_current_caps variable like this: Thanks for catching that! I've rebased your change into the original patch. - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
