Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 22, 2012 at 6:25 PM, Chris Ball <cjb@xxxxxxxxxx> wrote:
> Hi,
>
> On Fri, Jun 22 2012, T Krishnamoorthy, Balaji wrote:
>> On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
>>> This patch reverts the commit dba3c29ea4a1d5d544.
>>>
>>> After bisecting, this commit dba3c29 is found to ruin micro-SD card data
>>> (writing incorrect file, or fs is corrupt after several times mount)
>>> on the beagle-xm revB, and reverting the commit will fix the problem.
>>
>> Hi Ming,
>> Rather than reverting the entire commit,
>> Can you try with the below change alone, so that AutoCMD12 can be easily
>> enabled back when needed.
>>
>> @@ -1859,7 +1859,6 @@ static int __devinit omap_hsmmc_probe(st
>>       host->mapbase   = res->start + pdata->reg_offset;
>>       host->base      = ioremap(host->mapbase, SZ_4K);
>>       host->power_mode = MMC_POWER_OFF;
>> -     host->flags     = AUTO_CMD12;
>>       host->next_data.cookie = 1;
>>
>>       platform_set_drvdata(pdev, host);
>
> I'm not totally comfortable with that; seems like it should be harder
> to cause data corruption than turning on a single flag in the host.
>
> The full revert is probably best until we know what the underlying
> bug is, and how to disable AUTO_CMD12 on all affected systems.

I tested autocmd12 to be working on OMAP2,3,4 SDP. With beagle board
data corruption is observed with some cards, so it is going to be selectively
enabling/disabling for some SoCs via board data or DT until data corruption
due to Autocmd12 is root caused.

>
> Thanks,
>
> - Chris.
> --
> Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
> One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux