Re: [RFC PATCH] Revert "mmc: omap_hsmmc: Enable Auto CMD12"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 22, 2012 at 4:19 PM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
> This patch reverts the commit dba3c29ea4a1d5d544.
>
> After bisecting, this commit dba3c29 is found to ruin micro-SD card data
> (writing incorrect file, or fs is corrupt after several times mount)
> on the beagle-xm revB, and reverting the commit will fix the problem.
>
> Also from TRM of OMAP3/OMAP4/DM37x, the below is mentioned about
> the Auto CMD12 Enable bit.
>        - SDIO does not support this feature.
>        - SD card only.
> Looks it is not suitable to always enable Auto CMD12 in host controller
> driver.
>
> Considered that the commit is not mature enough, so ask to revert it
> first.
>
> Cc: Balaji T K <balajitk@xxxxxx>
> Cc: Venkatraman S <svenkatr@xxxxxx>
> Buglink: https://lkml.org/lkml/2012/6/10/225
> Reported-by: Paolo Pisati <p.pisati@xxxxxxxxx>
> Reported-bisected-and-tested-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>

Agreed. We can revert this and add it later when the behavior is well
understood.

Acked-by: Venkatraman S <svenkatr@xxxxxx>

> ---
>  drivers/mmc/host/omap_hsmmc.c |   15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux