Re: [PATCH v3] mmc: core: Fix the HPI execution sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 20, 2012 at 10:31 PM, Chris Ball <cjb@xxxxxxxxxx> wrote:
> Hi, trivial style comments,
>
> On Wed, Jun 20 2012, Venkatraman S wrote:
>>       switch (R1_CURRENT_STATE(status)) {
>>
>
> No newline here.
>
>>       case R1_STATE_IDLE:
>>       case R1_STATE_READY:
>>       case R1_STATE_STBY: /* intentional fall through */
>>               /* In idle states, HPI is not needed and the caller
>>                can issue the next intended command immediately */
>>               goto out;
>>               break;
>
> This might just be personal style, but I don't think of this as
> "intentional fall through" -- you're just matching multiple cases.
>
> Case fall-through would be if the code inside the cases didn't call
> goto or break at the end and kept going into the next code block,
> which doesn't happen here.  Here's an elegant use of fall-through:
>   http://chris.printf.net/btrfs_parse_size.txt

That's a cool trick !!

>
> I don't think you should bother using break after you've already
> called goto.
>
Thanks - I was circumspect about the goto & break thing myself.
> Also, please use:
> /*
>  * comment 1
>  * comment 2
>  */
>
> for multiline comments instead of
>
> /* comment 1
>  comment 2 */
>
I'll fix these and send a patch now.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux