Hi Johan and Chris, On 20 June 2012 09:27, Johan Rudholm <jrudholm@xxxxxxxxx> wrote: > Hi Chris, > > 2012/6/20 Chris Ball <cjb@xxxxxxxxxx>: >> Hi Johan, >> >> On Tue, Jun 12 2012, Johan Rudholm wrote: >>> Do not scan boot partitions for "soft" partitions, since the boot >>> partitions are supposed to contain boot code. Silences the following >>> message during boot: >>> >>> mmcblkXbootY: unknown partition table >>> >>> Signed-off-by: Johan Rudholm <johan.rudholm@xxxxxxxxxxxxxx> >>> --- >>> drivers/mmc/card/block.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c >>> index 7e3f453..efdea68 100644 >>> --- a/drivers/mmc/card/block.c >>> +++ b/drivers/mmc/card/block.c >>> @@ -1515,6 +1515,8 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card, >>> md->disk->queue = md->queue.queue; >>> md->disk->driverfs_dev = parent; >>> set_disk_ro(md->disk, md->read_only || default_ro); >>> + if (area_type & MMC_BLK_DATA_AREA_BOOT) >>> + md->disk->flags = GENHD_FL_NO_PART_SCAN; >>> >>> /* >>> * As discussed on lkml, GENHD_FL_REMOVABLE should: >> >> Would it be impossible to add a partition table to mmcblkXbootY, >> or just unlikely? > > I believe this is just an unlikely scenario since the boot partitions > are supposed to contain boot code and also because of their relatively > small size (a few MBs), but there is no technical problem. Perhaps it > should be left up to the user? RPMB partitions are an example of > partitions that would actually generate an error on partition scanning > (because they require authentication), but this is not the case for > boot partitions. > To me this looks like a fair constraint we can put on the boot partitions. It does not make sense to have a partition table in there. So I say go ahead with this patch. Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Kind regards Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
