Re: [PATCH v5] MMC-4.5 Power OFF Notify Rework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Girish,

On 14 June 2012 15:21, Girish K S <girish.shivananjappa@xxxxxxxxxx> wrote:
> On 14 June 2012 18:43, Per Forlin <per.lkml@xxxxxxxxx> wrote:
>> Hi Girish and Suagata,
>>
>> I have run some regression tests with this patch on our board (ux500
>> family) running suspend and resume of the eMMC 4.41 device.
>>
>> The two patches I have looked at are:
>> 1. "mmc: core: Fix PowerOff Notify suspend/resume" (merged)
>> 2. " MMC-4.5 Power OFF Notify Rework"
>>
>> With only patch #1 the eMMC doesn't power up after in resume() after
>> being suspended. The eMMC doesn't respond at all after suspend. It's
>> not powered up.
>> Running tests with #1 and #2, the card is powered up but it doesn't
>> wake up after CMD5. Commands that arrive are after resume/CMD5
>> timeouts. I even tried by increasing the awake timeout to 5 seconds
>> but i didn't help.
>>
>> The eMMC on my board successfully suspends and resumes with patch #1
>> and #2 if waking up the card using CMD0 (mmc_card_init()) instead of
>> CMD5.
>>
>> Have anyone else seen the same issue?
>> Have this patch been verified on a board together with eMMC 4.41 that
>> supports card power off.
> This rework patch is still under progress. we are modifying it. In our
> earlier discussions subhash has posted the
> same issue and a solution for this.  we should save ios context before
> sleep and restore ios before awake. soon rework patch will be
> posted with the above recomenedded solution.
>

I think the best solution is to always do mmc_card_init when doing
resume, it will be nice a simple.
Otherwise it will be somewhat tricky to keep track of what state we
are in, and if the ios should be restored or not.

Finally, I would be glad to help out in posting an updated version of
this patch, if that OK with you?

Kind regards
Ulf Hansson
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux