Hi Zhangfei,
On Tue, Jun 12 2012, zhangfei gao wrote:
> On Wed, Jun 13, 2012 at 3:05 AM, Chris Ball <cjb@xxxxxxxxxx> wrote:
>> Tested on an OLPC XO-1.75. (MMP2, sdhci-pxav3, CONFIG_MACH_MMP2_DT=y)
>>
>> Signed-off-by: Chris Ball <cjb@xxxxxxxxxx>
>> ---
>> .../devicetree/bindings/mmc/sdhci-pxa.txt | 21 ++++++++
>> drivers/mmc/host/sdhci-pxav2.c | 52 ++++++++++++++++++++
>> drivers/mmc/host/sdhci-pxav3.c | 50 +++++++++++++++++++
>> 3 files changed, 123 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
>
> Thanks Chris for the great help, compile error if CONFIG_OF not defined.
Thanks for catching this!
How do you feel about having the compatible node say "sdhci-pxav3"
instead of "mrvl,pxav3-mmc"? I used the mrvl prefix because it fits
in with the rest of your existing DT, but it seems like it would be
better to name the driver directly. The DTs here live inside the
source tree, so we're not depending on anyone else's terminology.
If you're okay with sdhci-pxav{2,3} in compatible, I'll include that
in v2 of the patch with the rest of your fixes.
- Chris.
--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
