Hi Mark On Mon, 28 May 2012, Mark Brown wrote: > On Fri, May 25, 2012 at 05:14:52PM +0200, Guennadi Liakhovetski wrote: > > Add a function to get a regulator, supplying card's Vdd on a specific host. > > If such a regulator is found, the function checks, whether a valid OCR mask > > can be obtained from this regulator. > > Reviwed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Thanks for the review! > but > > > +EXPORT_SYMBOL(mmc_regulator_get_vmmc); > > regulator is all _GPL... Yes, but existing mmc-regulator functions use EXPORT_SYMBOL(), e.g., EXPORT_SYMBOL(mmc_regulator_get_ocrmask); which indeed seem to do the "old evil binary-only module trick": re-export functions, dropping the "_GPL" suffix. Looks like they should be fixed... Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
