On 29 May 2012 03:32, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > On Mon, 2012-05-28 at 18:31 +0100, Torne (Richard Coles) wrote: >> From: "Torne (Richard Coles)" <torne@xxxxxxxxxx> >> >> MMC CSD info can specify very large, ridiculous timeouts, big enough to >> overflow timeout_ns on 32-bit machines. This can result in the card >> timing out on every operation because the wrapped timeout value is far >> too small. >> >> Fix the overflow by capping the result at 2 seconds. Cards specifying >> longer timeouts are almost certainly insane, and host controllers >> generally cannot support timeouts that long in any case. >> >> 2 seconds should be plenty of time for any card to actually function; >> the timeout calculation code is already using 1 second as a "worst case" >> timeout for cards running in SPI mode. > > Needs a 'Signed-off-by'. Oops, sorry. I'm still getting used to the patch workflow. Will resend. -- Torne (Richard Coles) torne@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
