Chris, Thanks. And my full name is Yong Ding. Best Wishes, Yong Ding Operating Systems Engineering, Application Processor Systems Engineering -----Original Message----- From: Chris Ball [mailto:cjb@xxxxxxxxxx] Sent: Thursday, May 17, 2012 8:38 PM To: Yong Ding Cc: linux-mmc@xxxxxxxxxxxxxxx; Philip Rakity; ohad@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; ulf.hansson@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH v2] mmc:sdio:guarantee setting card data bus width as 4-bit Hi, On Tue, May 15 2012, yongd wrote: > SDIO_CCCR_IF[1:0] in SDIO card is used for card data bus width > setting as below, > 00b: 1-bit bus > 01b: Reserved > 10b: 4-bit bus > 11b: 8-bit bus(only for embedded SDIO) > And sdio_enable_wide is for setting data bus width as 4-bit. But > currently, it 1stly read the register, 2ndly OR' 1b with SDIO_CCCR_IF[1], > and then write it back. > As we can see, such way is based on such assumption that the > SDIO_CCCR_IF[0] is always 0. Apparently, this is not right. > > Signed-off-by: yongd <yongd@xxxxxxxxxxx> Thanks. Can we have your full name, for the copyright record? - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
