On 4 May 2012 04:18, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: > > What do you think about this patch > > http://www.spinics.net/lists/linux-sh/msg11259.html > > and about using mmc-generic OF properties instead of creating yet another > copy of proprietary ones? Hi Guennadi, This patch does not intend to add any custom mmc properties. I checked your patch (in the link mentioned above) and most of the bindings are similar to what you have come up with except for the "ro-gpios" for which I have used "wp-gpios". But this is following what Arnd had proposed here: http://www.spinics.net/lists/linux-mmc/msg13564.html. Regarding the MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA in your patch, these can be derived from the bus width information that the driver receives. Thanks, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html