On Tue, Apr 24, 2012 at 06:41:45PM +0200, Guennadi Liakhovetski wrote:
> + host->vdd = regulator_get(mmc_dev(mmc), "SD Vdd");
> + if (IS_ERR(host->vdd)) {
> + host->vdd = NULL;
> + } else {
This silently ignoring errors really isn't good practice :(
> @@ -1052,6 +1079,7 @@ void tmio_mmc_host_remove(struct tmio_mmc_host *host)
>
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> + regulator_put(host->vdd);
devm_regulator_get() is there now.
Attachment:
signature.asc
Description: Digital signature
