The call to pm_runtime_put() in tmio-mmc's .set_ios() method can switch off the supplying clock or even power down the whole unit. Therefore, calling tmio_mmc_clk_stop() after that can be redundant, put it before. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Cc: Magnus Damm <magnus.damm@xxxxxxxxx> --- drivers/mmc/host/tmio_mmc_pio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index 9a7996a..0d2643b 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c @@ -809,11 +809,11 @@ static void tmio_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) } else if (ios->power_mode != MMC_POWER_UP) { if (host->set_pwr && ios->power_mode == MMC_POWER_OFF) host->set_pwr(host->pdev, 0); + tmio_mmc_clk_stop(host); if (host->power) { host->power = false; pm_runtime_put(dev); } - tmio_mmc_clk_stop(host); } switch (ios->bus_width) { -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html