Hi On Fri, 20 Apr 2012, Mark Brown wrote: > On Fri, Apr 20, 2012 at 06:59:41PM +0200, Guennadi Liakhovetski wrote: > > > +static struct gpio_regulator_state mmcif_power_states[] = { > > + { .value = 3300000, .gpios = 0 }, > > +}; > > It doesn't make much odds but if you've only got one voltage the fixed > voltage regulator is a little more idiomatic here (there's some overlap > as they've been evolving separately. No harm in gpio-regulator though. One more question in this respect: I see, that most other MMC drivers use "vmmc" as supply name. How important is it for all MMC drivers to use the same name? Shall I use it for MMCIF and TMIO-MMC too? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html