On Wed, Apr 11, 2012 at 20:14:47, Chris Ball wrote: > Hi, > > On Wed, Apr 11 2012, Ulf Hansson wrote: > > On 04/11/2012 01:54 PM, Chuanxiao Dong wrote: > >> MMC bus is using legacy suspend/resume method, which is not compatible if > >> runtime pm callbacks are used. In this scenario, MMC bus suspend/resume > >> callbacks cannot be called when system entering S3. So change to use the new > >> defined dev_pm_ops for system sleeping mode > >> > >> Signed-off-by: Chuanxiao Dong<chuanxiao.dong@xxxxxxxxx> > >> --- > >> Changes in v2: > >> use SET_SYSTEM_SLEEP_PM_OPS to define sleep callbacks as Rafael > >> suggested > >> > >> Changes in v3: > >> remove NULL pointer define for runtime callbacks when PM_RUNTIME is not > >> selected, as Ulf Hansson suggested > >> > >> Changes in v4: > >> fix the warning when disable CONFIG_PM_RUNTIME > >> > > > > Looks good to me! Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxxxxxx> > > Thanks! Pushed to mmc-next for 3.4. Can you consider my Tested-by for this patch. Tested on AM335x Platform. Solves major issue/crash reported at http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg65425.html Tested-by: Hebbar, Gururaja <gururaja.hebbar@xxxxxx> > > - Chris. > -- > Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> > One Laptop Per Child > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html