Hi Dmitry, Le 04/10/2012 09:06 PM, Dmitry Artamonow a écrit :
None of mmc host drivers using linux/blkdev.h header really need anything from it. The slight exception is atmel-mci, which uses blkdev.h only because it indirectly pulls asm/cacheflush.h So remove any inclusion of blkdev.h - it should also fix build errors of dw_mmc and atmel-mci drivers when CONFIG_BLOCK is disabled, like following: ------------------------------------------------------ In file included from drivers/mmc/host/dw_mmc.c:14:0: include/linux/blkdev.h:1408:42: warning: ‘struct task_struct’ declared inside parameter list [enabled by default] include/linux/blkdev.h:1408:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/linux/blkdev.h:1412:51: warning: ‘struct task_struct’ declared inside parameter list [enabled by default] include/linux/blkdev.h:1417:1: error: unknown type name ‘bool’ include/linux/blkdev.h:1417:48: warning: ‘struct task_struct’ declared inside parameter list [enabled by default] include/linux/blkdev.h: In function ‘blk_needs_flush_plug’: include/linux/blkdev.h:1419:9: error: ‘false’ undeclared (first use in this function) include/linux/blkdev.h:1419:9: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [drivers/mmc/host/dw_mmc.o] Error 1 make: *** [drivers/mmc/host/dw_mmc.o] Error 2 ------------------------------------------------------ Cc: Ludovic Desroches<ludovic.desroches@xxxxxxxxx> Cc: Pavel Pisa<ppisa@xxxxxxxxxx> Cc: Sascha Hauer<s.hauer@xxxxxxxxxxxxxx> Cc: Will Newton<will.newton@xxxxxxxxxx> Signed-off-by: Dmitry Artamonow<mad_soft@xxxxxxxx> --- drivers/mmc/host/at91_mci.c | 1 - drivers/mmc/host/atmel-mci.c | 2 +-
Acked-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxx> Thanks for your patch. Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
