On Tue, Apr 03, 2012 at 02:13:54, Per Forlin wrote: > On Fri, Mar 30, 2012 at 7:25 AM, Sujit Reddy Thumma > <sthumma@xxxxxxxxxxxxxx> wrote: > > On 3/30/2012 8:17 AM, NeilBrown wrote: > >> > >> ...snip... ...snip... > >> > >> The net effect is that - as I observed - mmc_bus_suspend is never called. > >> > >> I added lines: > >> > >> .suspend = mmc_bus_suspend, > >> .resume = mmc_bus_resume, > >> > >> to mmc_bus_pm_ops and can no longer reproduce the problem. So maybe this > >> patch is appropriate: > >> > >> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c > >> index 5d011a3..80c1e46 100644 > >> --- a/drivers/mmc/core/bus.c > >> +++ b/drivers/mmc/core/bus.c > >> @@ -169,6 +169,8 @@ static const struct dev_pm_ops mmc_bus_pm_ops = { > >> .runtime_suspend = mmc_runtime_suspend, > >> .runtime_resume = mmc_runtime_resume, > >> .runtime_idle = mmc_runtime_idle, > >> + .suspend = mmc_bus_suspend, > >> + .resume = mmc_bus_resume, > >> }; > >> > >> #define MMC_PM_OPS_PTR (&mmc_bus_pm_ops) > >> > >> however I suspect we should remove the 'legacy' pointers at the same > >> time.(?). > > > > This was pointed out earlier and a patch is posted but looks like it never > > went into mmc tree -- http://comments.gmane.org/gmane.linux.kernel.mmc/9168 > > We were also facing a similar issue related to mmc copy operation & suspend/resume from console. http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg65425.html We applied the above patch it started working properly. Acked by me for this patch ...snip... ...snip... > mmc_queue_suspend(). > > Regards, > Per > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html