Re: [PATCH v1 1/1] mmc: core: fix power class selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/4/3 Girish K S <girish.shivananjappa@xxxxxxxxxx>:
> On 3 April 2012 15:55, Subhash Jadavani <subhashj@xxxxxxxxxxxxxx> wrote:
>> mmc_select_powerclass() function returns error if eMMC
>> VDD level supported by host is between 2.7v to 3.2v.
>>
>> According to eMMC specification, valid voltage for high
>> voltage cards is 2.7v to 3.6v. This patch ensures that
>> 2.7v to 3.6v VDD range is treated as valid range.
>>
>> Also, failure to set the power class shouldn't be treated
>> as fatal error because even if setting the power class
>> fails, card can still work in default power class.
>> If mmc_select_powerclass() returns error, just print
>> the warning message and go ahead with rest of the card
>> initialization.
>>
>> Signed-off-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx>
> looks good to me
> Acked By:  Girish K S <girish.shivananjappa@xxxxxxxxxx>

I double checked with specification. this patch make good sense.
Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxx>

Thanks

>> --
>> 1.7.1.1
>>
>> --
>> Sent by a consultant of the Qualcomm Innovation Center, Inc.
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux