Re: [PATCH RESEND 4/8] mmc: omap: context save after enabling runtime pm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 15, 2012 at 8:42 PM, Shubhrajyoti <shubhrajyoti@xxxxxx> wrote:
> On Thursday 15 March 2012 08:03 PM, Venkatraman S wrote:
>> From: Balaji T K <balajitk@xxxxxx>
>>
>> call context save api after enabling runtime pm
>> to make sure register access in context save api
> If I am not mistaken  the api  would
> store the number of power state changes and accesses no registers.
>
> Am I missing something?

Yes, as of now no registers are accessed in context store. However
this patch is needed if registers are accessed in context save api.

>
>>  happens with clk enabled.
>>
>> Signed-off-by: Balaji T K <balajitk@xxxxxx>
>> ---
>>  drivers/mmc/host/omap_hsmmc.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 0f8d34b..9fa2f39 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -1871,8 +1871,6 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
>>               goto err1;
>>       }
>>
>> -     omap_hsmmc_context_save(host);
>> -
>>       if (host->pdata->controller_flags & OMAP_HSMMC_BROKEN_MULTIBLOCK_READ) {
>>               dev_info(&pdev->dev, "multiblock reads disabled due to 35xx erratum 2.1.1.128; MMC read performance may suffer\n");
>>               mmc->caps2 |= MMC_CAP2_NO_MULTI_READ;
>> @@ -1883,6 +1881,8 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
>>       pm_runtime_set_autosuspend_delay(host->dev, MMC_AUTOSUSPEND_DELAY);
>>       pm_runtime_use_autosuspend(host->dev);
>>
>> +     omap_hsmmc_context_save(host);
>> +
>>       if (cpu_is_omap2430()) {
>>               host->dbclk = clk_get(&pdev->dev, "mmchsdb_fck");
>>               /*
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux