On Thu, Mar 15, 2012 at 02:53:29PM +0800, Lothar Waßmann wrote: > Hi, > > Dong Aisheng writes: > > On Wed, Mar 14, 2012 at 10:16:43PM +0800, s.hauer@xxxxxxxxxxxxxx wrote: > > > On Wed, Mar 14, 2012 at 08:45:23PM +0800, Dong Aisheng wrote: > > > > On Wed, Mar 14, 2012 at 01:23:51AM +0800, Grant Likely wrote: > [...] > > > > But it seems this needs pass mac address to fec driver via platforom data which is > > > > not friendly to dt. > > > > > > > > Another way may be changing fec driver to get the fixed part of mac address(first > > > > two bytes) from device tree and read the left dynamical part from otp which i'm not > > > > sure is better enough. > > > > > > > > BTW, filling with zeros seems not work since it's invalid mac address. > > > > > > Yes, that's the idea of using this value... > > > > > But comparing to use an invalid value, why not just do not define that > > local-mac-address property? > > > Because a MAC address is by definition a GLOBALLY UNIQUE IDENTIFIER > which is contrary to coding a "valid" default value for it somewhere! > The owner of a certain MAC address range (OUI) is responsible for > ensuring the uniqueness. Thus only they may assign a specific MAC > address to a specific device. > Yes, you're correct. So i propose to read the MAC address from MX28 OTP in fec driver instead of define it in device tree in my last mail. http://www.spinics.net/lists/arm-kernel/msg165040.html Do you have any comment on that way? Regards Dong Aisheng -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
