On Tue, 13 Mar 2012 09:59:39 -0500, Zach Sadecki <zsadecki@xxxxxxxxxxxxxxx> wrote: > On 03/13/2012 09:35 AM, Rob Herring wrote: > > + ahb@80080000 { > > + fec@800f0000 { > > Use generic names: ethernet@800f0000 > Generic is good, but consistency is better, IMHO. grepping existing dts > files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@" > >> + uart1: uart@80074000 { > > Use generic names: uart1: serial@... > Same comment here, but unfortunately there is already inconsistency in > existing files... 25 instances of "serial@" and 35 instances of "uart@" No, Rob is correct. The generic names recommended practice is well established and documented. Expand your grep search to include arch/powerpc/bot/dts/*. See section 2.2.2 of ePAPR[1] [1]https://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.1.pdf -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html