Re: [PATCH 3/3] sh_mmcif / PM: Use PM QoS requests, v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, March 06, 2012, Guennadi Liakhovetski wrote:
> On Sun, 4 Mar 2012, Rafael J. Wysocki wrote:
> 
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > 
> > Make sh_mmcif populate the pm_qos member of struct mmc_host, to
> > let the core know that it should create the pm_latency_limit_ms
> > host attribute for it, and set the default value of that attribute
> > to 100 ms.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > ---
> >  drivers/mmc/host/sh_mmcif.c |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > Index: linux/drivers/mmc/host/sh_mmcif.c
> > ===================================================================
> > --- linux.orig/drivers/mmc/host/sh_mmcif.c
> > +++ linux/drivers/mmc/host/sh_mmcif.c
> > @@ -57,6 +57,7 @@
> >  #include <linux/pagemap.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_runtime.h>
> > +#include <linux/slab.h>
> >  #include <linux/spinlock.h>
> >  #include <linux/module.h>
> >  
> > @@ -1327,6 +1328,12 @@ static int __devinit sh_mmcif_probe(stru
> >  	if (ret < 0)
> >  		goto clean_up2;
> >  
> > +	mmc->pm_qos = kzalloc(sizeof(*mmc->pm_qos), GFP_KERNEL);
> > +	if (mmc->pm_qos)
> > +		mmc->pm_qos->val = 100;
> 
> Same comments as for tmio_mmc: embed pm_qos

That wouldn't work.

> and reduce the value?

The value will be fine when the units are correct.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux