2012/2/16 Kukjin Kim <kgene.kim@xxxxxxxxxxx>: > On 02/14/12 14:03, Jaehoon Chung wrote: >> >> >> Signed-off-by: Jaehoon Chung<jh80.chung@xxxxxxxxxxx> >> Signed-off-by: Kyungmin-park<kyungmin.park@xxxxxxxxxxx> >> --- >> arch/arm/plat-samsung/include/plat/sdhci.h | 59 +------------------- >> include/linux/mmc/sdhci-s3c.h | 84 >> ++++++++++++++++++++++++++++ >> 2 files changed, 85 insertions(+), 58 deletions(-) >> create mode 100644 include/linux/mmc/sdhci-s3c.h >> > Hi, > > I don't agree with this. > Basically, the components(struct s3c_sdhci_platdata and some enums) you > moved here are just for platform data on each board in arch/arm/. Hi Mr. Kukjin. I didn't think so. That components are the board specific. right? For example, dw_mmc.h and sdhci-spear.h are included the board-data. But that didn't locate in arch/arm/. there are linux/mmc/. I think no problem that move to linux/mmc/. But that's right that s3cxxx_setup_sdhci0_cfg_gpio() or exynos_setup_sdhciX_cfg_gpio located in arch/arm/. That's platdata but that is also generic platdata. That platdata structure didn't change whatever. What's problem? Best Regards, Jaehoon Chung > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
