Hi, On Wed, Feb 01 2012, Jurgen Heeks wrote: > Found this issue during code review. Actually, there are two > issues which both compensate together in lucky case. > In unlucky case the bus width probing might not work as expected. > > Signed-off-by: Jurgen Heeks <JURGEN.HEEKS@xxxxxxxxx> > --- > drivers/mmc/core/mmc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index f6ac0a4..4f06c43 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -353,7 +353,7 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) > } > > card->ext_csd.raw_hc_erase_gap_size = > - ext_csd[EXT_CSD_PARTITION_ATTRIBUTE]; > + ext_csd[EXT_CSD_HC_WP_GRP_SIZE]; > card->ext_csd.raw_sec_trim_mult = > ext_csd[EXT_CSD_SEC_TRIM_MULT]; > card->ext_csd.raw_sec_erase_mult = > @@ -451,7 +451,7 @@ static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width) > goto out; > > /* only compare read only fields */ > - err = (!(card->ext_csd.raw_partition_support == > + err = !((card->ext_csd.raw_partition_support == > bw_ext_csd[EXT_CSD_PARTITION_SUPPORT]) && > (card->ext_csd.raw_erased_mem_count == > bw_ext_csd[EXT_CSD_ERASED_MEM_CONT]) && Thanks very much, Jurgen! Pushed to mmc-next for 3.3 with Namjae's Reviewed-by. - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
