Hi Heiko, On Wed, Jan 11, 2012 at 13:58:56, Heiko Schocher wrote: > Hello, > > Heiko Schocher wrote: > > The MMC driver allocates channels with EVENTQ_DEFAULT, they > > get put into EVENTQ_1, which the second EDMA controller does > > not have and hence transfers stall. This is fixed > > in commit f23fe857bbea393b4b94fe2218c98d934bd3d4cf > > "ARM: davinci: Explicitly set channel controllers' default queues" > > from Ido Yariv. This patch sets immediately in edma_probe() > > the proper default_queue, so this patch does not really fix > > something, it is more a cosmetic change. > > > > Signed-off-by: Heiko Schocher <hs@xxxxxxx> > > Signed-off-by: juha.kuikka@xxxxxxxxx > > Reported-by: juha.kuikka@xxxxxxxxx > > Acked-by: Rajashekhara, Sudhakar <sudhakar.raj@xxxxxx> > > Cc: linux-mmc@xxxxxxxxxxxxxxx > > Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx > > Cc: Rajashekhara, Sudhakar <sudhakar.raj@xxxxxx> > > Cc: Ido Yariv <ido@xxxxxxxxxx> > > Cc: Sekhar Nori <nsekhar@xxxxxx> > > Cc: Wolfgang Denk <wd@xxxxxxx> > > Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxx> > > > > --- > > - changes for v2: > > - add comment from Sergei Shtylyov > > add in commit message the commit's summary in parens. > > - add comment from Ido Yariv: > > changed comment and commit message > > - added Acked-by from Rajashekhara, Sudhakar > > > > arch/arm/mach-davinci/dma.c | 10 ++++++---- > > 1 files changed, 6 insertions(+), 4 deletions(-) > > Ping. Can this patch go into mainline, or are there some more objections? Hmm, looks like you asking "no need for applying my patch" in an earlier e-mail on this topic made me discard this. I had a look and the patch is OK. Except, I think the comment can do better without reference to TC1 since its not relevant once the code has been fixed. Also, the comment is better placed in edma.h where near the default_queue member definition since that's where folks will look up when setting up the default queue. So, the comment can simply be: + /* + * Default queue is expected to be a low-priority queue. + * This way, long transfers on the default queue started + * by the codec engine will not cause audio defects. Similarly you can drop references to the MMC/SD issue and the fix in the commit text since its not directly relevant to your patch. Can you fix this up so I can apply it? Please note that patches for mach-davinci should be pre-fixed with "ARM: davinci: ". Also Cc linux-arm-kernel@xxxxxxxxxxxxxxxxxxx on ARM patch submissions. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
