On Wed, Jan 4, 2012 at 11:17 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> Now, that all users of tmio_mmc_cd_wakeup() have been converted over to
> drivers/mmc/core/cd-gpio.c, that function can be removed.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
> include/linux/mfd/tmio.h | 11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index 4ef9307..08fb7d2 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -4,7 +4,6 @@
> #include <linux/device.h>
> #include <linux/fb.h>
> #include <linux/io.h>
> -#include <linux/jiffies.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
>
> @@ -110,16 +109,6 @@ struct tmio_mmc_data {
> };
>
> /*
> - * This function is deprecated and will be removed soon. Please, convert your
> - * platform to use drivers/mmc/core/cd-gpio.c
> - */
> -static inline void tmio_mmc_cd_wakeup(struct tmio_mmc_data *pdata)
> -{
> - if (pdata)
> - mmc_detect_change(dev_get_drvdata(dev), msecs_to_jiffies(100));
> -}
> -
> -/*
Ok, I can clearly see the merit of removing unused code. And I do
appreciate that you clean up the code. Thank you!
The only issue is that we do however have tons of users of the SDHI
driver (just grep in arch/arm/mach-shmobile and in arch/sh) and many
of them can use other pins than the SDHI CD function for hotplug
detection. To support such configurations we need to have some way to
notify the driver instance about the hotplug change. This patch is
removing just that.
I do realize that you recently posted some generic MMC GPIO hotplug
patches, and I am happy that you agreed with me that it is better to
put it in the generic MMC core than pushing it in the SDHI or MMCIF
driver. So this development seems like a perfect fit for both the SDHI
driver and the MMCIF driver.
I'd like to see platforms move over to your MMC GPIO hotplug helpers,
but at the same time I want to keep the existing notification method
to make a smooth transition. I personally added GPIO IRQ support
rather recently to SH Mobile ARM, but it is still rather early and we
do not have many users yet. I have seen customer-specific hardware
designs using non-GPIO pins for CD handling too, and to support such
hardware we want to keep flexible notification methods. So with that
in mind I'd like to keep the options open and allow fully developed
platforms to use your MMC GPIO hotplug code, but also allow custom
platforms and boards/SoCs with more limited software support handle
hotplug notification the old way.
So please don't remove this function at this point. Give us time to move over.
Thanks,
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
