On 13 December 2011 11:57, Seungwon Jeon <tgih.jun@xxxxxxxxxxx> wrote: > Hi Saugata, > > Saugata Das wrote: >> Hi Seungwon Jeon >> >> I see a small issue with the implementation mmc_suspend_host, >> >> int mmc_suspend_host(struct mmc_host *host) >> { >> ..... >> err = mmc_cache_ctrl(host, 0); >> } >> >> So, within mmc_suspend_host we are disabling the cache. But I do not >> see a corresponding enabling of cache within mmc_resume_host. I >> suggest we have either enabling of cache within mmc_resume_host or >> within mmc_suspend_host, we replace mmc_cache_ctrl(host, 0) with the >> flush operation, mmc_flush_cache(host->card). >> > Currently, > Cache is enabled in mmc_init_card() during mmc_resume_host(). > Thanks for your answer. If mmc_card_keep_power is TRUE, then do you know why from mmc_resume we call mmc_init_card instead of just mmc_awake which should reduce some latency of system wakeup ? > Thanks, > Seungwon Jeon. >> >> >> Regards >> Saugata >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html