On Monday 12 December 2011, Shashidhar Hiremath wrote:
> @@ -39,6 +39,9 @@ struct mmc_ioc_cmd {
>
> /* DAT buffer */
> __u64 data_ptr;
> + /* The error status for the Command sent */
> + unsigned int error;
> +
> };
> #define mmc_ioc_cmd_set_data(ic, ptr) ic.data_ptr = (__u64)(unsigned long) ptr
I fear you cannot do this: This changes the ABI in an incompatible way. If you
have an application built against the previous version, you will now overwrite
random data in that application when the kernel stores the error number.
You are also changing the structure layout in a way that makes it incompatible
between 32 and 64 bit processes. Why can't you just return the error value
and not return anything else in case of cmd.error != 0?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
