Hello Rajashekhara, Rajashekhara, Sudhakar wrote: > On Wed, Dec 07, 2011 at 11:52:23, Heiko Schocher wrote: >> Hello Sekhar, >> >> here the forwarded comment from Ido Yariv to my patch. I tried >> with current kernel MMC Controller 2 on my am1808 based board >> without my fix, and it works fine, so no need for applying my >> patch. >> >> Thanks >> bye, >> Heiko >> >> here the message from Ido: >> >> Betreff: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue >> Datum: Mon, 5 Dec 2011 10:35:10 +0200 >> Von: Ido Yariv <ido@xxxxxxxxxx> >> An: hs@xxxxxxx >> CC: juha.kuikka@xxxxxxxxx > > I think Ido replied to only you and Juha, that's why even I am not able to see his reply on the list. Ah, yes, you are right, sorry missed that ... >> Referenzen: <1322991210-20486-1-git-send-email-hs@xxxxxxx> <20111204102741.GL32400@WorkStation> <4EDC7C00.30603@xxxxxxx> >> >> Hi Heiko, >> >> On Dec 5, 2011 10:08 AM, "Heiko Schocher" <hs@xxxxxxx> wro >>> Ok ... patch not longer needed, but isn't it better to setup here >>> immediately the right values? If so, I can sent a v2 with your >>> suggested comment change. >> These are just default values which will get overwritten later on, so im >> not sure if it matters much. I guess it wouldn't hurt to use default_queue >> instead of queue 1. >> > > It would have helped if you posted the complete message here but I figured > this out. I assume that Ido's explanation is as below: Hmm.. that was the complete message ... > EDMA channel is allocated in MMC driver through the call to > edma_alloc_channel() api and the last argument passed to this api is the > event queue number. Currently the event queue number being passed is > EVENTQ_DEFAULT. Inside edma_alloc_channel() there is a call to > map_dmach_queue() which also takes event queue number as argument. > map_dmach_queue() function initializes the event queue number to > default_queue (being passed from platform data), if it is EVENTQ_DEFAULT. Yep, fully correct. > I wanted to know why MMC/SD was not working initially for you even with > this piece of code? Because I tested with Linux-3.1 where this patch wasn't included ... >> In any case, if you do chose to submit v2, the commit message should also >> be changed if it doesnt really fix anything. > > I would still say, your patch is the clean way of addressing the issue. > May be you can modify the commit message as Ido has pointed out. Ok, send a v2, thanks! > Sekhar, do you have any comments? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
