> -----Original Message----- > From: Hein_Tibosch [mailto:hein_tibosch@xxxxxxxx] > Sent: Tuesday, December 06, 2011 8:13 PM > To: Huang Changming-R66093 > Cc: linux-mmc@xxxxxxxxxxxxxxx; Huang Changming-R66093; Chris Ball > Subject: Re: [PATCH 1/5 v2] MMC/core: Make sure the power is up, when > detect the card > > Hi Jerry, > > On 12/6/2011 5:18 PM, r66093@xxxxxxxxxxxxx wrote: > > From: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx> > > > > Before running get_cd() recall function to detect whether the card is > > present, must make sure the power is up. > > > > Signed-off-by: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx> > > CC: Chris Ball <cjb@xxxxxxxxxx> > > --- > > changes for v2: > > - add the CC > > > > drivers/mmc/core/core.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index > > 5278ffb..a08e6b1 100644 > > --- a/drivers/mmc/core/core.c > > +++ b/drivers/mmc/core/core.c > > @@ -2066,8 +2066,10 @@ void mmc_rescan(struct work_struct *work) > > */ > > mmc_bus_put(host); > > > > + mmc_power_up(host); > > If get_cd is not defined, a power-up for sure isn't necessary: > > > if (host->ops->get_cd && host->ops->get_cd(host) == 0) > > goto out; > > Did you intent to leave it powered-up in case get_cd() fails? > En, it is one bug, I will fix it -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
