Hi Guennadi, On Thu, Dec 1, 2011 at 12:07 AM, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: > This patch converts the sh_mmcif MMC host driver to process requests > asynchronously instead of waiting in its .request() method for completion. > This is achieved by using threaded IRQs. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Thanks for your work on this! Interesting with threaded IRQ support. Would it be possible to split this up into smaller chunks somehow? This rather big patch is more or less a rewrite of the driver - so it somehow looks to me like you're implementing multiple functional changes in a single commit. Maybe you're not doing that, but if so then at least the new code flow needs some documentation. How about including some ascii-art style charts of the different states involved in reads and writes both for PIO and DMA? I'm thinking of something similar to the comments that describe the bus transaction and interrupts in drivers/i2c/busses/i2c-sh_mobile.c. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
