Hi Chris, 2011/12/2 Axel Lin <axel.lin@xxxxxxxxx>: > 2011/12/2 Chris Ball <cjb@xxxxxxxxxx>: >> Hi Axel, Micha, >> >> On Fri, Nov 25 2011, Axel Lin wrote: >>> This patch converts the drivers in drivers/mmc/host/* to use the >>> module_platform_driver() macro which makes the code smaller and a bit >>> simpler. >> >> This makes cb710_mmc unhappy: >> >> /home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning: data definition has no type or storage class [enabled by default] >> /home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning: type defaults to ‘int’ in declaration of ‘module_platform_driver’ [-Wimplicit-int] >> /home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning: parameter names (without types) in function declaration [enabled by default] >> /home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:773:31: warning: ‘cb710_mmc_driver’ defined but not used [-Wunused-variable] > > Strange. I don't see above warning in my build after apply this patch. > ( Tested on linux-next tree ). > I found the problem now. It is because the define of module_platform_driver does not exist in your mmc-next branch. However, it does exist in your master branch. ( see include/linux/platform_device.h ) Axel -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
